<html>
<head><meta charset="utf-8"><title>Implement String::matches #71780 · t-libs · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/index.html">t-libs</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html">Implement String::matches #71780</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="209201952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/209201952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#209201952">(Sep 06 2020 at 00:32)</a>:</h4>
<p>This PR (<a href="https://github.com/rust-lang/rust/pull/71780">https://github.com/rust-lang/rust/pull/71780</a>) is waiting on team consensus</p>



<a name="209219898"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/209219898" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pickfire <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#209219898">(Sep 06 2020 at 10:52)</a>:</h4>
<p>I think the PR have a few comments that needs to be resolved first.</p>



<a name="209219908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/209219908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pickfire <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#209219908">(Sep 06 2020 at 10:53)</a>:</h4>
<p><span class="user-mention" data-user-id="118772">@Lukas Kalbertodt</span> I feel that <code>str</code> and <code>slice</code> behaves very differently as for Pattern API.</p>



<a name="209219920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/209219920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pickfire <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#209219920">(Sep 06 2020 at 10:53)</a>:</h4>
<p><code>str</code> is more flexible while <code>slice</code> is very restrictive, a lot of signatures is very different so one cannot just convert <code>str</code> Pattern API methods to <code>slice</code>.</p>



<a name="209417359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/209417359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#209417359">(Sep 08 2020 at 17:20)</a>:</h4>
<p>Uhm, I'm not sure I understand your message :/</p>



<a name="209417395"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/209417395" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Kalbertodt <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#209417395">(Sep 08 2020 at 17:20)</a>:</h4>
<p>Also note that I haven't followed any pattern API design discussions...</p>



<a name="211262574"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/211262574" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Lew <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#211262574">(Sep 25 2020 at 14:10)</a>:</h4>
<p>Ping from triage, any updates on this issue?</p>



<a name="211262650"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/211262650" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Lew <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#211262650">(Sep 25 2020 at 14:10)</a>:</h4>
<p>Ping from triage, any updates on this issue?</p>



<a name="211423552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/211423552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pickfire <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#211423552">(Sep 27 2020 at 16:27)</a>:</h4>
<p>There were some comments but the developer didn't update the code according the comments. Also, now the developer is busy and someone else needs to take over.</p>



<a name="211423612"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/211423612" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pickfire <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#211423612">(Sep 27 2020 at 16:28)</a>:</h4>
<p>One thing is function constraint being weird and another one being not an efficient implementation which requires to allocate twice.</p>



<a name="211424344"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/211424344" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#211424344">(Sep 27 2020 at 16:50)</a>:</h4>
<p>it needs redesign of the pattern API I think</p>



<a name="211424387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/211424387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#211424387">(Sep 27 2020 at 16:50)</a>:</h4>
<p>which is not something the author should really be responsible for</p>



<a name="226695008"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/226695008" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#226695008">(Feb 17 2021 at 17:38)</a>:</h4>
<p>This PR has been labeled <code>S-waiting-on-team</code>, hence will be included in the T-compiler meeting agenda of tomorrow:<br>
<a href="https://hackmd.io/deNj8imkTaSwe4MloUeZDw#PRs-S-waiting-on-team">https://hackmd.io/deNj8imkTaSwe4MloUeZDw#PRs-S-waiting-on-team</a></p>
<p>if anyone wants, feel free to jump in and/or add details/fixes to the summary I wrote about it</p>



<a name="226712095"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/226712095" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#226712095">(Feb 17 2021 at 19:28)</a>:</h4>
<p>Oh it was waiting on the libs team, i guess. We discussed it last week and <span class="user-mention" data-user-id="204346">@Ashley Mannix</span> said he'd look at it. I re-labeled as T-libs-impl because it's not a new stabilization, but forgot to remove the waiting-on-team label.</p>



<a name="226737581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/226737581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#226737581">(Feb 17 2021 at 22:26)</a>:</h4>
<p>ok, then I'll remove that label myself (hope it's fine, otherwise I'll put it back ^^)</p>



<a name="226738773"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/Implement%20String%3A%3Amatches%20%2371780/near/226738773" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Ashley Mannix <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/Implement.20String.3A.3Amatches.20.2371780.html#226738773">(Feb 17 2021 at 22:36)</a>:</h4>
<p>I am going to look at this soon <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span> FWIW it’ll probably land with the HRTB and then block stabilization on reworking the pattern API to avoid it</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>